surahman commented on a change in pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r836003034
##########
File path: heron/tools/ui/src/python/main.py
##########
@@ -614,9 +653,11 @@ def cli(
host: str, port: int, base_url_option: str, tracker_url_option: str,
verbose: bool
) -> None:
"""Start a web UI for heron which renders information from the tracker."""
- global base_url, tracker_url
+ global base_url, tracker_url, Log
base_url = base_url_option
- log.configure(level=logging.DEBUG if verbose else logging.INFO)
+ log_level = logging.DEBUG if verbose else logging.INFO
+ log.configure(log_level)
+ Log = log.Log
Review comment:
> I can put these 3 lines back to the original line I replaced. Feel
free to submit any edit suggestions.
If you need a fresh copy of the logger here we will need to rename the
variable or suppress the style check warnings. The issue that then crops up is
that the `Log` variable is assigned in the method where it is declared, but it
is never used. That is why I thought your intent was to update the globally
defined `Log`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
