surahman commented on a change in pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r836908354
##########
File path: heron/tools/tracker/tests/python/app_unittest.py
##########
@@ -34,19 +34,31 @@ def test_clusters(client, tracker):
tracker.state_managers = [c1, c2]
response = client.get("/clusters")
- assert response.json() == ok(["c1", "c2"])
+ assert response.json() == ok({'executiontime': 0.0,
+ 'message': 'ok',
+ 'result': {},
+ 'status': 'success',
+ 'tracker_version': '0.1.0'})
assert response.status_code == 200
def test_machines(client):
response = client.get("/machines", json={
"cluster": ["c1", "c3"],
"environ": ["e1", "e3"],
})
- assert response.json() == ok({})
+ assert response.json() == ok({'executiontime': 0.0,
+ 'message': 'ok',
+ 'result': {},
+ 'status': 'success',
+ 'tracker_version': '0.1.0'})
def test_topologies(client):
response = client.get("/topologies", json={
"cluster": [],
"environ": [],
})
- assert response.json() == ok({})
+ assert response.json() == ok({'executiontime': 0.0,
+ 'message': 'ok',
+ 'result': {},
+ 'status': 'success',
+ 'tracker_version': '0.1.0'})
Review comment:
These tests should be updated to match what needs to be happening in the
production code. I have tried to update them based on what I think needs to be
happening. You are better positioned to update them depending on what you put
together in the production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
