surahman edited a comment on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1080854038
There are multiple test failures, some of which are justified, and others that require updates to the test suite. The following failures are related to the JSON responses. I think you are better positioned to review and update the tests depending on how you designed the production code. https://github.com/apache/incubator-heron/blob/af7053ec8162ec43ea7b58d4ddf746ff2b2ab43d/heron/tools/tracker/tests/python/app_unittest.py#L37-L38 https://github.com/apache/incubator-heron/blob/af7053ec8162ec43ea7b58d4ddf746ff2b2ab43d/heron/tools/tracker/tests/python/app_unittest.py#L45 https://github.com/apache/incubator-heron/blob/af7053ec8162ec43ea7b58d4ddf746ff2b2ab43d/heron/tools/tracker/tests/python/app_unittest.py#L52 **_EDIT:_** I have pushed some test changes to the repo for the failing integration tests above. **These tests should not be updated unless the production logic surrounding them has been updated to handle the output in the tests.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
