surahman commented on a change in pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r837016420
##########
File path: heron/tools/tracker/src/python/query_operators.py
##########
@@ -150,11 +150,11 @@ async def execute(
raise Exception(metrics["message"])
# Put a blank timeline.
- if not metrics.get("timeline"):
- metrics["timeline"] = {
+ if not metrics.timeline:
+ metrics.timeline = {
Review comment:
The changes are in commit fc8efabef837d68a8be7175d2d326bc7a2ddc3cc. This
brings the functionality back to spec with the original tests so that they are
no longer failing. We should not require any further changes related to the
specific commit I mentioned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
