nwangtw commented on a change in pull request #3109: Add withStream() in
Streamlet to support stream selection
URL: https://github.com/apache/incubator-heron/pull/3109#discussion_r233947029
##########
File path: heron/api/src/java/org/apache/heron/streamlet/Streamlet.java
##########
@@ -71,6 +71,22 @@
*/
int getNumPartitions();
+ /**
+ * Set the id of the stream to be used by the children nodes.
+ * Usage (assuming source is a Streamlet object with two output streams:
stream1 and stream2):
+ * source.withStream("stream1").filter(...).log();
+ * source.withStream("stream2").filter(...).log();
+ * @param streamId The specified stream id
+ * @return Returns back the Streamlet with changed stream id
+ */
+ Streamlet<R> withStream(String streamId);
+
+ /**
+ * Gets the stream id of this Streamlet.
+ * @return the stream id of this Streamlet
+ */
+ String getStreamId();
Review comment:
In fact, I am thinking of adding the split() operator now with this PR so
that we can add a proper IT for it. I prefer to break PR down to single
functionality but in this case it could be useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
