nwangtw commented on a change in pull request #3109: Add withStream() in
Streamlet to support stream selection
URL: https://github.com/apache/incubator-heron/pull/3109#discussion_r235276449
##########
File path: heron/api/src/java/org/apache/heron/streamlet/Streamlet.java
##########
@@ -71,6 +71,22 @@
*/
int getNumPartitions();
+ /**
+ * Set the id of the stream to be used by the children nodes.
+ * Usage (assuming source is a Streamlet object with two output streams:
stream1 and stream2):
+ * source.withStream("stream1").filter(...).log();
+ * source.withStream("stream2").filter(...).log();
+ * @param streamId The specified stream id
+ * @return Returns back the Streamlet with changed stream id
+ */
+ Streamlet<R> withStream(String streamId);
+
+ /**
+ * Gets the stream id of this Streamlet.
+ * @return the stream id of this Streamlet
+ */
+ String getStreamId();
Review comment:
In fact, still no....
The problem is the .setName and .setPartition functions, like:
numberStreamlets.split(splitter).setName("split").setPartition(10);
the split operator is one single bolt and all entries in Map<String,
Streamlet> points to the same bolt. It might be ok to set name and partition
like:
Map<String, Streamlet> splittedStreamlets =
numberStreamlets.split(splitter);
splittedStreamlets.get("even").setName("split")
splittedStreamlets.get("even").setPartition(partition)
but it looks really bad this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
