nwangtw commented on a change in pull request #3109: Add withStream() in 
Streamlet to support stream selection
URL: https://github.com/apache/incubator-heron/pull/3109#discussion_r235228682
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/streamlet/Streamlet.java
 ##########
 @@ -71,6 +71,22 @@
    */
   int getNumPartitions();
 
+  /**
+   * Set the id of the stream to be used by the children nodes.
+   * Usage (assuming source is a Streamlet object with two output streams: 
stream1 and stream2):
+   *   source.withStream("stream1").filter(...).log();
+   *   source.withStream("stream2").filter(...).log();
+   * @param streamId The specified stream id
+   * @return Returns back the Streamlet with changed stream id
+   */
+  Streamlet<R> withStream(String streamId);
+
+  /**
+   * Gets the stream id of this Streamlet.
+   * @return the stream id of this Streamlet
+   */
+  String getStreamId();
 
 Review comment:
   "Map<String, Streamlet<Integer>>"  won't really work because right now one 
Streamlet is mapped to one operator which is a Bolt component. In our case, 
there is only one component (hence one streamlet object) with multiple streams.
   
   I had to add a StreamletShadow class to create companion objects of the main 
Streamlet object in my implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to