vinothchandar commented on a change in pull request #651: Spark Stage retry
handling
URL: https://github.com/apache/incubator-hudi/pull/651#discussion_r285228751
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/HoodieWriteClient.java
##########
@@ -1270,7 +1278,7 @@ protected void commitCompaction(JavaRDD<WriteStatus>
compactedStatuses, HoodieTa
String compactionCommitTime, boolean autoCommit, Optional<Map<String,
String>> extraMetadata) {
if (autoCommit) {
HoodieCommitMetadata metadata =
- doCompactionCommit(compactedStatuses, table.getMetaClient(),
compactionCommitTime, extraMetadata);
+ doCompactionCommit(table, compactedStatuses, table.getMetaClient(),
compactionCommitTime, extraMetadata);
Review comment:
nit: can we then get rid of the need to pass `table.getMetaClient()`
explictly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
