vinothchandar commented on a change in pull request #651: Spark Stage retry 
handling
URL: https://github.com/apache/incubator-hudi/pull/651#discussion_r285282086
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/io/HoodieIOHandle.java
 ##########
 @@ -63,50 +71,64 @@ public HoodieIOHandle(HoodieWriteConfig config, String 
commitTime, HoodieTable<T
         config.getWriteStatusFailureFraction());
   }
 
+  private static FileSystem getFileSystem(HoodieTable hoodieTable, 
HoodieWriteConfig config) {
+    return new HoodieWrapperFileSystem(hoodieTable.getMetaClient().getFs(), 
config.isConsistencyCheckEnabled()
+        ? 
FSUtils.getFailSafeConsistencyGuard(hoodieTable.getMetaClient().getFs(),
 
 Review comment:
   FSUtils is typically a medley of parsing code right?  should the method 
construction the guard sit somewhere . else ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to