vinothchandar commented on a change in pull request #651: Spark Stage retry 
handling
URL: https://github.com/apache/incubator-hudi/pull/651#discussion_r285288345
 
 

 ##########
 File path: 
hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieLogFile.java
 ##########
 @@ -96,7 +96,11 @@ public FileStatus getFileStatus() {
     return fileStatus;
   }
 
-  public HoodieLogFile rollOver(FileSystem fs) throws IOException {
+  public void setFileStatus(FileStatus fileStatus) {
+    this.fileStatus = fileStatus;
+  }
+
+  public HoodieLogFile rollOver(FileSystem fs, String logWriteToken) throws 
IOException {
 
 Review comment:
   If you can obtain logWriteToken from log file, do we use the same one when 
rolling over? would n't that cause two concurrent writers to use the same one? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to