bvaradar commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r285360185
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CommitsCommand.java
##########
@@ -131,8 +133,13 @@ public String rollbackCommit(@CliOption(key = {"commit"},
help = "Commit to roll
}
SparkLauncher sparkLauncher = SparkUtil.initLauncher(sparkPropertiesPath);
- sparkLauncher
- .addAppArgs(SparkMain.SparkCommand.ROLLBACK.toString(), commitTime,
HoodieCLI.tableMetadata.getBasePath());
+
+ HoodieCommitRollbackJobConfig config = new HoodieCommitRollbackJobConfig();
Review comment:
@abhioncbr : Firstly, Thanks a lot for your motivation to contribute to
Apache Hudi. Much appreciated.
To explain our reasoning regarding centralization of configs, all these CLI
config classes have their logical scope only inside their corresponding
commands. If the scope of the class is broader or part of public API directly
used by users implementation (for e:g - HoodieWriteConfig), then it can be a
first-level class along with builders for validation. This is the convention we
have followed to hide information/complexities where it should be.
Also, most importantly, hoodie-common is expected to contain only
core-classes
that are used across different environments (hive/spark/presto) and
(read/write/compact).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
