bvaradar commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r290043742
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CompactionCommand.java
##########
@@ -209,26 +219,36 @@ public String scheduleCompact(
@CliCommand(value = "compaction run", help = "Run Compaction for given
instant time")
public String compact(
- @CliOption(key = {"parallelism"}, mandatory = true, help = "Parallelism
for hoodie compaction")
- final String parallelism,
- @CliOption(key = "schemaFilePath", mandatory = true, help = "Path for
Avro schema file")
- final String schemaFilePath,
- @CliOption(key = "sparkMemory", unspecifiedDefaultValue = "4G", help =
"Spark executor memory")
- final String sparkMemory,
- @CliOption(key = "retry", unspecifiedDefaultValue = "1", help = "Number
of retries")
- final String retry,
- @CliOption(key = "compactionInstant", mandatory = true, help = "Base
path for the target hoodie dataset")
- final String compactionInstantTime) throws Exception {
+ @CliOption(key = {
Review comment:
Is this part of auto-formatting ? Seeing many such changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
