bvaradar commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r285359888
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CommitsCommand.java
##########
@@ -131,8 +133,13 @@ public String rollbackCommit(@CliOption(key = {"commit"},
help = "Commit to roll
}
SparkLauncher sparkLauncher = SparkUtil.initLauncher(sparkPropertiesPath);
- sparkLauncher
- .addAppArgs(SparkMain.SparkCommand.ROLLBACK.toString(), commitTime,
HoodieCLI.tableMetadata.getBasePath());
+
+ HoodieCommitRollbackJobConfig config = new HoodieCommitRollbackJobConfig();
+ config.basePath = HoodieCLI.tableMetadata.getBasePath();
+ config.commitTime = commitTime;
+ String[] jobConfig =
config.getJobConfigsAsCommandOption(SparkCommand.ROLLBACK.name());
Review comment:
Is HoodieCommitRollbackJobConfig expected to be used for commands other than
ROLLBACk ?
If HoodieCommitRollbackJobConfig is specific to ROLLBACK command, can you
make it a constant inside HoodieCommitRollbackJobConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
