vinothchandar commented on a change in pull request #674: Upgrade to Hive 2.x,
MOR read query fixes and performance improvement
URL: https://github.com/apache/incubator-hudi/pull/674#discussion_r291866728
##########
File path:
hoodie-hadoop-mr/src/main/java/com/uber/hoodie/hadoop/realtime/AbstractRealtimeRecordReader.java
##########
@@ -90,17 +89,21 @@
protected final HoodieRealtimeFileSplit split;
protected final JobConf jobConf;
private final MessageType baseFileSchema;
-
+ protected final boolean usesCustomPayload;
// Schema handles
private Schema readerSchema;
private Schema writerSchema;
public AbstractRealtimeRecordReader(HoodieRealtimeFileSplit split, JobConf
job) {
this.split = split;
this.jobConf = job;
-
+ // NOTE : The following does not work for a select count(*) in Hive 1.x
Review comment:
is this comment relevant, given we are dropping support for Hive 1.x? or we
are not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
