vinothchandar commented on a change in pull request #674: Upgrade to Hive 2.x,
MOR read query fixes and performance improvement
URL: https://github.com/apache/incubator-hudi/pull/674#discussion_r291867121
##########
File path:
hoodie-hadoop-mr/src/main/java/com/uber/hoodie/hadoop/realtime/AbstractRealtimeRecordReader.java
##########
@@ -262,8 +280,8 @@ public static Writable avroToArrayWritable(Object value,
Schema schema) {
mapValues[1] = avroToArrayWritable(mapEntry.getValue(),
schema.getValueType());
values3[index3++] = new ArrayWritable(Writable.class, mapValues);
}
- wrapperWritable = new Writable[]{new ArrayWritable(Writable.class,
values3)};
- return new ArrayWritable(Writable.class, wrapperWritable);
+ // Hive 1.x will fail here, it requires values3 to be wrapped into
another ArrayWritable
Review comment:
given these are simple wrapper methods, should we support a jobConf property
like `hoodie.hive.recordreader.hive1mode=true` and return whats needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
