vinothchandar commented on a change in pull request #674: Upgrade to Hive 2.x,
MOR read query fixes and performance improvement
URL: https://github.com/apache/incubator-hudi/pull/674#discussion_r291863371
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/HoodieAvroUtils.java
##########
@@ -197,6 +198,22 @@ public static GenericRecord rewriteRecord(GenericRecord
record, Schema newSchema
return newRecord;
}
+ /**
+ * Given a avro record with a given schema, rewrites it into the new schema
Review comment:
can we share the common code between this method and the `rewriteRecord`
above, by refactoring this into a third method `rewriteRecord(GenericRecord,
Schema, Schema)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
