vinothchandar commented on a change in pull request #692: HUDI-70 : Making
DeltaStreamer run in continuous mode with concurrent compaction
URL: https://github.com/apache/incubator-hudi/pull/692#discussion_r292152632
##########
File path:
hoodie-utilities/src/main/java/com/uber/hoodie/utilities/UtilHelpers.java
##########
@@ -131,8 +133,8 @@ public static String parseSchema(FileSystem fs, String
schemaFile) throws Except
return new String(buf.array());
}
- private static SparkConf buildSparkConf(String appName, String
defaultMaster) {
- SparkConf sparkConf = new SparkConf().setAppName(appName);
+ private static SparkConf buildSparkConf(String appName, String
defaultMaster, Map<String, String> additionalConfigs) {
Review comment:
have an overloaded method instead with just takes 2 params and passes down
an empty map?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
