vinothchandar commented on a change in pull request #692: HUDI-70 : Making
DeltaStreamer run in continuous mode with concurrent compaction
URL: https://github.com/apache/incubator-hudi/pull/692#discussion_r294585440
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/CompactionAdminClient.java
##########
@@ -65,7 +65,7 @@
private static Logger log =
LogManager.getLogger(CompactionAdminClient.class);
public CompactionAdminClient(JavaSparkContext jsc, String basePath) {
- super(jsc, HoodieWriteConfig.newBuilder().withPath(basePath).build());
+ super(jsc, HoodieWriteConfig.newBuilder().withPath(basePath).build(),
java.util.Optional.empty());
Review comment:
otherwise, every piece of code needs to remember the special meaning of
Optional.empty arg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services