vinothchandar commented on a change in pull request #692: HUDI-70 : Making
DeltaStreamer run in continuous mode with concurrent compaction
URL: https://github.com/apache/incubator-hudi/pull/692#discussion_r294585159
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/AbstractHoodieClient.java
##########
@@ -47,13 +48,17 @@
* of the cached file-system view. New completed actions will be synced
automatically
* in an incremental fashion.
*/
- private transient EmbeddedTimelineService timelineServer;
+ private transient Optional<EmbeddedTimelineService> timelineServer;
+ private final boolean timelineServerOwner;
Review comment:
this basically controls whether we stop the timeline server after use or
not? can we just name it `shouldStopTimelineServer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
