[
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920180#comment-16920180
]
Vinoth Chandar commented on HUDI-233:
-------------------------------------
[~xleesf] I am working on thinning the amount of dependencies we have in Hudi
to reduce probability of clashing with external systems/runtime environments it
integrates with. One of them I just removed is slf4j.. While I am not against
the specific framework (I obviously pretty good), I feel we need to be lean
towards having our helper wrappers for this sort of stuff vs bringing in new
dependencies just for this..
Can we revisit this in a week or two when I have better idea about how this
will affect shading/bundling? thoughts?
> Redo log statements using {} variable substitution
> --------------------------------------------------
>
> Key: HUDI-233
> URL: https://issues.apache.org/jira/browse/HUDI-233
> Project: Apache Hudi (incubating)
> Issue Type: Bug
> Components: newbie, Performance
> Affects Versions: 0.5.0
> Reporter: Vinoth Chandar
> Assignee: leesf
> Priority: Major
>
> Currently we are not employing variable substitution aggresively in the
> project. ala
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail:
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to
> when the logging is actually in effect.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
