[ 
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922329#comment-16922329
 ] 

leesf commented on HUDI-233:
----------------------------

> If you can shed more light on how we would package slf4j, that would be 
> great? From your description, may be we can skip bundling slf4j for hive and 
> spark, but include it for presto? 

Yes. we need to move back slf4j again for logging, Exclude slf4j for hive/spark 
and include it for presto.

> Redo log statements using {} variable substitution
> --------------------------------------------------
>
>                 Key: HUDI-233
>                 URL: https://issues.apache.org/jira/browse/HUDI-233
>             Project: Apache Hudi (incubating)
>          Issue Type: Bug
>          Components: newbie, Performance
>    Affects Versions: 0.5.0
>            Reporter: Vinoth Chandar
>            Assignee: leesf
>            Priority: Major
>
> Currently we are not employing variable substitution aggresively in the 
> project.  ala 
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail: 
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to 
> when the logging is actually in effect.  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to