[
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921881#comment-16921881
]
Vinoth Chandar commented on HUDI-233:
-------------------------------------
Fair enough. May be unfounded. but worried about issues like this
[https://github.com/apache/incubator-hudi/issues/735]
> So do we have to remove the slf4j dependency?
To clarify, I just removed slf4j since it was not being used uniformly anyway.
Most of the code was using log4j.
If you can shed more light on how we would package slf4j, that would be great?
From your description, may be we can skip bundling slf4j for hive and spark,
but include it for presto?
> Redo log statements using {} variable substitution
> --------------------------------------------------
>
> Key: HUDI-233
> URL: https://issues.apache.org/jira/browse/HUDI-233
> Project: Apache Hudi (incubating)
> Issue Type: Bug
> Components: newbie, Performance
> Affects Versions: 0.5.0
> Reporter: Vinoth Chandar
> Assignee: leesf
> Priority: Major
>
> Currently we are not employing variable substitution aggresively in the
> project. ala
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail:
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to
> when the logging is actually in effect.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
