vinothchandar commented on a change in pull request #928: [HUDI-265] Failed to 
delete tmp dirs created in unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#discussion_r329070467
 
 

 ##########
 File path: 
hudi-common/src/test/java/org/apache/hudi/common/table/log/HoodieLogFormatTest.java
 ##########
 @@ -78,6 +80,8 @@
 @RunWith(Parameterized.class)
 public class HoodieLogFormatTest {
 
+  @Rule
+  public TemporaryFolder folder = new TemporaryFolder();
 
 Review comment:
   I am wondering if we should reuse @yanghua 's work here. May be create a 
thin HoodieCommonTestHarness class and make it extend the 
HoodieClientTestHarness and make these tests subclass HoodieCommonTestHarness? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to