vinothchandar commented on a change in pull request #928: [HUDI-265] Failed to 
delete tmp dirs created in unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#discussion_r329069160
 
 

 ##########
 File path: 
hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
 ##########
 @@ -968,6 +968,7 @@ public void testInsertsGeneratedIntoLogFilesRollback() 
throws Exception {
       Thread.sleep(1000);
       // Rollback again to pretend the first rollback failed partially. This 
should not error our
       writeClient.rollback(newCommitTime);
+      folder.delete();
 
 Review comment:
   does nt this happen already at the HoodieClientTestHarness level? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to