vinothchandar commented on a change in pull request #928: [HUDI-265] Failed to
delete tmp dirs created in unit tests
URL: https://github.com/apache/incubator-hudi/pull/928#discussion_r329071805
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/table/log/HoodieLogFormatTest.java
##########
@@ -78,6 +80,8 @@
@RunWith(Parameterized.class)
public class HoodieLogFormatTest {
+ @Rule
Review comment:
+1 on using the `@Rule` wondering if that will give us auto deletion.. I
think it's deleted in afterClass of the test.
https://stackoverflow.com/questions/16494459/why-isnt-junit-temporaryfolder-deleted
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
