leesf commented on a change in pull request #1050: [HUDI-368]: code clean up in
TestAsyncCompaction class
URL: https://github.com/apache/incubator-hudi/pull/1050#discussion_r355991790
##########
File path: hudi-client/src/test/java/org/apache/hudi/TestAsyncCompaction.java
##########
@@ -248,8 +238,7 @@ public void testScheduleIngestionBeforePendingCompaction()
throws Exception {
metaClient = new HoodieTableMetaClient(jsc.hadoopConfiguration(),
cfg.getBasePath());
HoodieInstant pendingCompactionInstant =
metaClient.getActiveTimeline().filterPendingCompactionTimeline().firstInstant().get();
- assertTrue("Pending Compaction instant has expected instant time",
- pendingCompactionInstant.getTimestamp().equals(compactionInstantTime));
+ assertEquals("Pending Compaction instant has expected instant time",
pendingCompactionInstant.getTimestamp(), compactionInstantTime);
Review comment:
line 246 `HoodieTableMetaClient metaClient = new
HoodieTableMetaClient(jsc.hadoopConfiguration(), cfg.getBasePath());` would be
removed too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
