leesf commented on a change in pull request #1050: [HUDI-368]: code clean up in TestAsyncCompaction class URL: https://github.com/apache/incubator-hudi/pull/1050#discussion_r355992635
########## File path: hudi-client/src/test/java/org/apache/hudi/TestAsyncCompaction.java ########## @@ -552,16 +535,14 @@ private void executeCompaction(String compactionInstantTime, HoodieWriteClient c FileStatus[] allFiles = HoodieTestUtils.listAllDataFilesInPath(table.getMetaClient().getFs(), cfg.getBasePath()); HoodieTableFileSystemView view = new HoodieTableFileSystemView(table.getMetaClient(), table.getCompletedCommitsTimeline(), allFiles); - List<HoodieDataFile> dataFilesToRead = view.getLatestDataFiles().collect(Collectors.toList()); - return dataFilesToRead; + return view.getLatestDataFiles().collect(Collectors.toList()); } private List<FileSlice> getCurrentLatestFileSlices(HoodieTable table, HoodieWriteConfig cfg) throws IOException { Review comment: remove throws IOException? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services