yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362358202
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java
##########
@@ -196,34 +196,34 @@ public void scan() {
HoodieLogBlock lastBlock = currentInstantLogBlocks.peek();
// handle corrupt blocks separately since they may not have
metadata
if (lastBlock.getBlockType() == CORRUPT_BLOCK) {
- LOG.info("Rolling back the last corrupted log block read
in " + logFile.getPath());
+ LOG.info("Rolling back the last corrupted log block read
in {}", logFile.getPath());
currentInstantLogBlocks.pop();
numBlocksRolledBack++;
} else if (lastBlock.getBlockType() != CORRUPT_BLOCK
&&
targetInstantForCommandBlock.contentEquals(lastBlock.getLogBlockHeader().get(INSTANT_TIME)))
{
// rollback last data block or delete block
- LOG.info("Rolling back the last log block read in " +
logFile.getPath());
+ LOG.info("Rolling back the last log block read in {}",
logFile.getPath());
currentInstantLogBlocks.pop();
numBlocksRolledBack++;
} else if (!targetInstantForCommandBlock
.contentEquals(currentInstantLogBlocks.peek().getLogBlockHeader().get(INSTANT_TIME)))
{
// invalid or extra rollback block
- LOG.warn("TargetInstantTime " +
targetInstantForCommandBlock
- + " invalid or extra rollback command block in " +
logFile.getPath());
+ LOG.warn("TargetInstantTime {} invalid or extra rollback
command block in {}",
+ targetInstantForCommandBlock, logFile.getPath());
Review comment:
Here, maybe there is one redundant indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
