yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362363286
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/FailSafeConsistencyGuard.java
##########
@@ -104,7 +104,7 @@ public void waitForFilesVisibility(String dirPath,
List<String> files, FileVisib
return candidateFiles.isEmpty();
}
} catch (IOException ioe) {
- LOG.warn("Got IOException waiting for file event. Have tried " +
retryNum + " time(s)", ioe);
+ LOG.warn(String.format("Got IOException waiting for file event. Have
tried %s time(s)", retryNum), ioe);
Review comment:
ditto about using placeholder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
