yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362358327
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java
##########
@@ -93,11 +93,11 @@
}
if (!isAppendSupported) {
this.logFile = logFile.rollOver(fs, rolloverLogWriteToken);
- LOG.info("Append not supported.. Rolling over to " + logFile);
+ LOG.info("Append not supported.. Rolling over to {}", logFile);
createNewFile();
}
} else {
- LOG.info(logFile + " does not exist. Create a new file");
+ LOG.info("{} does not exist. Create a new file", logFile.getPath());
Review comment:
Shall we use `logFile.getPath()` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
