yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362358513
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -63,12 +63,12 @@
public static final SimpleDateFormat COMMIT_FORMATTER = new
SimpleDateFormat("yyyyMMddHHmmss");
public static final Set<String> VALID_EXTENSIONS_IN_ACTIVE_TIMELINE = new
HashSet<>(Arrays.asList(
- new String[]{COMMIT_EXTENSION, INFLIGHT_COMMIT_EXTENSION,
REQUESTED_COMMIT_EXTENSION, DELTA_COMMIT_EXTENSION,
Review comment:
Can we revert this change? This PR aims to replace the log framework, right?
Let's do one thing in a PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
