alexeykudinkin commented on a change in pull request #4556:
URL: https://github.com/apache/hudi/pull/4556#discussion_r791350598
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java
##########
@@ -166,10 +169,12 @@ void testRollbackWithDeltaAndCompactionCommit(boolean
rollbackUsingMarkers) thro
JavaRDD<HoodieRecord> writeRecords = jsc().parallelize(records, 1);
JavaRDD<WriteStatus> writeStatusJavaRDD = client.upsert(writeRecords,
newCommitTime);
- client.commit(newCommitTime, writeStatusJavaRDD);
+
List<WriteStatus> statuses = writeStatusJavaRDD.collect();
assertNoWriteErrors(statuses);
+ client.commit(newCommitTime, jsc().parallelize(statuses));
+
Review comment:
These tests are actually written incorrectly -- they're dereferencing
RDDs twice w/in `commit` and when the collect w/in the state itself. This leads
to same base-files being double-written, which in turn fails assertion that i
currently put in place to make sure that legacy flow and the new one yield
identical results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
