alexeykudinkin commented on a change in pull request #4556:
URL: https://github.com/apache/hudi/pull/4556#discussion_r791350725
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java
##########
@@ -201,8 +206,10 @@ void testRollbackWithDeltaAndCompactionCommit(boolean
rollbackUsingMarkers) thro
copyOfRecords = dataGen.generateUpdates(commitTime1, copyOfRecords);
copyOfRecords.addAll(dataGen.generateInserts(commitTime1, 200));
- List<String> dataFiles =
tableView.getLatestBaseFiles().map(HoodieBaseFile::getPath).collect(Collectors.toList());
- List<GenericRecord> recordsRead =
HoodieMergeOnReadTestUtils.getRecordsUsingInputFormat(hadoopConf(), dataFiles,
+ List<String> inputPaths = tableView.getLatestBaseFiles()
+ .map(baseFile -> new
Path(baseFile.getPath()).getParent().toString())
+ .collect(Collectors.toList());
Review comment:
Preserving existing behavior (hence keeping lists instead of Sets)
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java
##########
@@ -268,11 +281,13 @@ void testRollbackWithDeltaAndCompactionCommit(boolean
rollbackUsingMarkers) thro
thirdClient.startCommitWithTime(newCommitTime);
writeStatusJavaRDD = thirdClient.upsert(writeRecords, newCommitTime);
+
statuses = writeStatusJavaRDD.collect();
- thirdClient.commit(newCommitTime, writeStatusJavaRDD);
// Verify there are no errors
assertNoWriteErrors(statuses);
+ thirdClient.commit(newCommitTime, jsc().parallelize(statuses));
+
Review comment:
Replied above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
