alexeykudinkin commented on a change in pull request #4556:
URL: https://github.com/apache/hudi/pull/4556#discussion_r791354207
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java
##########
@@ -361,15 +386,19 @@ void testMultiRollbackWithDeltaAndCompactionCommit()
throws Exception {
copyOfRecords = dataGen.generateUpdates(newCommitTime, copyOfRecords);
copyOfRecords.addAll(dataGen.generateInserts(newCommitTime, 200));
- List<String> dataFiles = tableView.getLatestBaseFiles().map(hf ->
hf.getPath()).collect(Collectors.toList());
+ List<String> dataFiles = tableView.getLatestBaseFiles()
+ .map(baseFile -> new
Path(baseFile.getPath()).getParent().toString())
+ .collect(Collectors.toList());
List<GenericRecord> recordsRead =
HoodieMergeOnReadTestUtils.getRecordsUsingInputFormat(hadoopConf(), dataFiles,
basePath());
assertEquals(200, recordsRead.size());
statuses = nClient.upsert(jsc().parallelize(copyOfRecords, 1),
newCommitTime).collect();
// Verify there are no errors
assertNoWriteErrors(statuses);
- nClient.commit(newCommitTime, writeStatusJavaRDD);
+
+ nClient.commit(newCommitTime, jsc().parallelize(statuses));
+
Review comment:
These are not cosmetic -- these are real test failures fixes (fixes
base-files double-writing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
