n3nash commented on a change in pull request #1274: [HUDI-571] Add 'commits 
show archived' command to CLI
URL: https://github.com/apache/incubator-hudi/pull/1274#discussion_r371422362
 
 

 ##########
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
 ##########
 @@ -49,34 +60,76 @@
  * This class can be serialized and de-serialized and on de-serialization the 
FileSystem is re-initialized.
  */
 public class HoodieArchivedTimeline extends HoodieDefaultTimeline {
+  private static final Pattern ARCHIVE_FILE_PATTERN =
+          Pattern.compile("^\\.commits_\\.archive\\.([0-9]*)$");
 
   private static final String HOODIE_COMMIT_ARCHIVE_LOG_FILE = "commits";
 
 Review comment:
   I'm referring to this variable `HOODIE_COMMIT_ARCHIVE_LOG_FILE` that stores 
just the string `commits`, how is that related to the regex ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to