n3nash commented on a change in pull request #1274: [HUDI-571] Add 'commits
show archived' command to CLI
URL: https://github.com/apache/incubator-hudi/pull/1274#discussion_r372574591
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -143,6 +143,83 @@ public HoodieTimeline filter(Predicate<HoodieInstant>
filter) {
return new HoodieDefaultTimeline(instants.stream().filter(filter),
details);
}
+ /**
+ * Get all instants (commits, delta commits) that produce new data, in the
active timeline.
+ */
+ public HoodieTimeline getCommitsTimeline() {
Review comment:
@vinothchandar can you ack that this is okay to move to this class ? This
way the ArchivedTimeline can also use these methods (and is aligned with our
thoughts on having the same operations on archived and active timeline..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
