satishkotha commented on a change in pull request #1274: [HUDI-571] Add
'commits show archived' command to CLI
URL: https://github.com/apache/incubator-hudi/pull/1274#discussion_r371584059
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -289,11 +288,8 @@ public ConsistencyGuardConfig getConsistencyGuardConfig()
{
*
* @return Active commit timeline
*/
- public synchronized HoodieArchivedTimeline getArchivedTimeline() {
- if (archivedTimeline == null) {
- archivedTimeline = new HoodieArchivedTimeline(this);
- }
- return archivedTimeline;
+ public synchronized HoodieArchivedTimeline getArchivedTimeline(String
startTs, String endTs) {
Review comment:
I initially wanted to do that. But HoodieDefaultTimeline(base class) keeps
track of instants in private class variable. And we do all filtering operations
on top of that. So, if we reuse same HoodieArchivedTimeline object, we will
likely have to change structure of how instants are kept in memory for base
class. I can talk to you more in person tomorrow. But right now, i prefer
creating multiple instances of archived timeline because its less error prone
IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
