alexeykudinkin commented on a change in pull request #4743:
URL: https://github.com/apache/hudi/pull/4743#discussion_r806198279
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieTableInputFormat.java
##########
@@ -0,0 +1,54 @@
+package org.apache.hudi.hadoop;
+
+import org.apache.hadoop.conf.Configurable;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.ArrayWritable;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.mapred.FileInputFormat;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.JobConf;
+
+import java.io.IOException;
+
+/**
+ * Abstract base class of the Hive's {@link FileInputFormat} implementations
allowing for reading of Hudi's
+ * Copy-on-Write (COW) and Merge-on-Read (MOR) tables
+ */
+public abstract class HoodieTableInputFormat extends
FileInputFormat<NullWritable, ArrayWritable>
+ implements Configurable {
+
+ protected Configuration conf;
+
+ @Override
+ public final Configuration getConf() {
+ return conf;
+ }
+
+ @Override
+ public final void setConf(Configuration conf) {
+ this.conf = conf;
+ }
+
+ @Override
+ protected boolean isSplitable(FileSystem fs, Path filename) {
+ return super.isSplitable(fs, filename);
+ }
+
+ @Override
+ protected FileSplit makeSplit(Path file, long start, long length, String[]
hosts) {
+ return super.makeSplit(file, start, length, hosts);
+ }
+
+ @Override
+ protected FileSplit makeSplit(Path file, long start, long length, String[]
hosts, String[] inMemoryHosts) {
+ return super.makeSplit(file, start, length, hosts, inMemoryHosts);
+ }
+
+ @Override
+ protected FileStatus[] listStatus(JobConf job) throws IOException {
+ return super.listStatus(job);
+ }
Review comment:
It's subtle: Parquet based hierarchy isn't inheriting from this one so
they can't access these methods (which are protected in `FileInputFormat`).
Having them re-declared here they now can b/c this class is w/in the same
package as those classes trying to access them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
