alexeykudinkin commented on a change in pull request #4743:
URL: https://github.com/apache/hudi/pull/4743#discussion_r808434585
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
##########
@@ -147,18 +148,21 @@ public WriteOperationType getOperationType() {
* been touched multiple times in the given commits, the return value will
keep the one
* from the latest commit.
*
+ *
+ * @param hadoopConf
* @param basePath The base path
* @return the file full path to file status mapping
*/
- public Map<String, FileStatus> getFullPathToFileStatus(String basePath) {
+ public Map<String, FileStatus> getFullPathToFileStatus(Configuration
hadoopConf, String basePath) {
Map<String, FileStatus> fullPathToFileStatus = new HashMap<>();
for (List<HoodieWriteStat> stats : getPartitionToWriteStats().values()) {
// Iterate through all the written files.
for (HoodieWriteStat stat : stats) {
String relativeFilePath = stat.getPath();
Path fullPath = relativeFilePath != null ?
FSUtils.getPartitionPath(basePath, relativeFilePath) : null;
if (fullPath != null) {
- FileStatus fileStatus = new FileStatus(stat.getFileSizeInBytes(),
false, 0, 0,
+ long blockSize = FSUtils.getFs(fullPath.toString(),
hadoopConf).getDefaultBlockSize(fullPath);
Review comment:
Let me check. The reason why i'm fixing this is b/c w/ block-size 0 Hive
will slice the file in 1 byte blocks.
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieCopyOnWriteTableInputFormat.java
##########
@@ -73,20 +74,7 @@
*
* NOTE: This class is invariant of the underlying file-format of the files
being read
*/
-public class HoodieCopyOnWriteTableInputFormat extends
FileInputFormat<NullWritable, ArrayWritable>
- implements Configurable {
-
- protected Configuration conf;
-
- @Override
- public final Configuration getConf() {
- return conf;
- }
-
- @Override
- public final void setConf(Configuration conf) {
Review comment:
They still stay, just moved into `HoodieTableInputFormat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
