alexeykudinkin commented on a change in pull request #4743:
URL: https://github.com/apache/hudi/pull/4743#discussion_r808444333
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieMergeOnReadTableInputFormat.java
##########
@@ -235,20 +258,117 @@ protected FileSplit makeSplit(Path file, long start,
long length, String[] hosts
return result;
}
- private FileSplit doMakeSplitForPathWithLogFilePath(PathWithLogFilePath
path, long start, long length, String[] hosts, String[] inMemoryHosts) {
- if (!path.includeBootstrapFilePath()) {
- return path.buildSplit(path, start, length, hosts);
- } else {
+ private FileSplit doMakeSplitForRealtimePath(HoodieRealtimePath path, long
start, long length, String[] hosts, String[] inMemoryHosts) {
+ if (path.includeBootstrapFilePath()) {
FileSplit bf =
inMemoryHosts == null
? super.makeSplit(path.getPathWithBootstrapFileStatus(), start,
length, hosts)
: super.makeSplit(path.getPathWithBootstrapFileStatus(), start,
length, hosts, inMemoryHosts);
- return
HoodieRealtimeInputFormatUtils.createRealtimeBoostrapBaseFileSplit(
+ return createRealtimeBoostrapBaseFileSplit(
(BootstrapBaseFileSplit) bf,
path.getBasePath(),
path.getDeltaLogFiles(),
path.getMaxCommitTime(),
- path.getBelongsToIncrementalQuery());
+ path.getBelongsToIncrementalQuery(),
+ path.getVirtualKeyInfo()
+ );
+ }
+
+ return createRealtimeFileSplit(path, start, length, hosts);
+ }
+
+ private static boolean containsIncrementalQuerySplits(List<FileSplit>
fileSplits) {
Review comment:
Mostly. `createRealtimeFileStatusUnchecked` also refactored to
accommodate for `RealtimeFileStatus` changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
