danny0405 commented on code in PR #6276:
URL: https://github.com/apache/hudi/pull/6276#discussion_r936411525
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -124,10 +124,8 @@ public FileSystemViewManager getViewManager() {
return viewManager;
}
- public boolean canReuseFor(String basePath) {
- return this.server != null
- && this.viewManager != null
- && this.basePath.equals(basePath);
+ public boolean canReuse() {
+ return this.server != null && this.viewManager != null;
}
Review Comment:
Did you know that we currently used the timeline service started by the
driver ? When the driver starts, it tries to start a `TimelineService` first,
and all the workers then access this service, the service is per-job singleton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
