trushev commented on code in PR #6276:
URL: https://github.com/apache/hudi/pull/6276#discussion_r936456114
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -124,10 +124,8 @@ public FileSystemViewManager getViewManager() {
return viewManager;
}
- public boolean canReuseFor(String basePath) {
- return this.server != null
- && this.viewManager != null
- && this.basePath.equals(basePath);
+ public boolean canReuse() {
+ return this.server != null && this.viewManager != null;
}
Review Comment:
Example:
```java
tEnv.executeSql("create table t1 (...) with ('path'='/tmp/t1', ...)")
tEnv.executeSql("create table t2 (...) with ('path'='/tmp/t2', ...)")
TableResult r1 = tEnv.executeSql("insert into t1 ...")
TableResult r2 = tEnv.executeSql("insert into t2 ...")
waitFotCommittedTableT1()
TableResult r3 = tEnv.executeSql("insert into t1 ...")
r1.await() // at this moment PATH_TO_SERVER = {/tmp/t1: timelineService1,
/tmp/t2: timelineService2}
r2.await() // and SERVER_TO_COUNTER = {timelineService1: 2,
timelineService2: 1}
r3.await()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
