trushev commented on code in PR #6276:
URL: https://github.com/apache/hudi/pull/6276#discussion_r936423380
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -124,10 +124,8 @@ public FileSystemViewManager getViewManager() {
return viewManager;
}
- public boolean canReuseFor(String basePath) {
- return this.server != null
- && this.viewManager != null
- && this.basePath.equals(basePath);
+ public boolean canReuse() {
+ return this.server != null && this.viewManager != null;
}
Review Comment:
> started by the driver
you mean `StreamWriteOperatorCoordinator`?
> all the workers then access this service
as I can see it is true only for workers with the same `basePath`
Yes I understand that service is per-job singleton. In some way it is
preserved by this PR: we have singleton for workers based on the same `basePath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
