trushev commented on code in PR #6276:
URL: https://github.com/apache/hudi/pull/6276#discussion_r937377702
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -124,10 +124,8 @@ public FileSystemViewManager getViewManager() {
return viewManager;
}
- public boolean canReuseFor(String basePath) {
- return this.server != null
- && this.viewManager != null
- && this.basePath.equals(basePath);
+ public boolean canReuse() {
+ return this.server != null && this.viewManager != null;
}
Review Comment:
Well I can check what happens if both
`/tmp/t1/.aux/view_storage_conf.properties`,
`/tmp/t2/.aux/view_storage_conf.properties` contain the same timeline service
but this logic it is missing on the lates master. Currenlty, we start new
timeline service and reassign `Option<EmbeddedTimelineService> TIMELINE_SERVER`
when new `basePath` is passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
