trushev commented on code in PR #6276:
URL: https://github.com/apache/hudi/pull/6276#discussion_r937371673
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -124,10 +124,8 @@ public FileSystemViewManager getViewManager() {
return viewManager;
}
- public boolean canReuseFor(String basePath) {
- return this.server != null
- && this.viewManager != null
- && this.basePath.equals(basePath);
+ public boolean canReuse() {
+ return this.server != null && this.viewManager != null;
}
Review Comment:
Yes I argee with you. This PR does not change it. I'm talking about we need
two singletons of timeline service when we have two different ${base_path}. It
is possible in example above where paths:
`/tmp/t1/.aux/view_storage_conf.properties`
`/tmp/t2/.aux/view_storage_conf.properties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
