garyli1019 commented on issue #1486: [HUDI-759] Integrate checkpoint privoder with delta streamer URL: https://github.com/apache/incubator-hudi/pull/1486#issuecomment-612171042 Addressed some comments, summary: - Removed `--bootstrap-from` option in the delta streamer. Use `hoodie.deltastreamer.checkpoint.provider.path` field in the props instead. - Use TypedProperty to construct the `InitialCheckPointProvider` and `init(FileSystem fs)` to initialize the class - Keep `hiveConf` as the variable name even change `HiveConf` type to `Configuration`. Open to discussion if you guys don't agree. - Not able to replace all `null` in this PR because `null` was served as a flag in the delta streamer workflow, this might change the behavior of other classes using the `TypedProperty` field. Will need a separate PR to do the code refactoring. - The style check tool automatically adds `final` and `this` to match the stylecheck.xml.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
