garyli1019 commented on a change in pull request #1486: [HUDI-759] Integrate
checkpoint privoder with delta streamer
URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r406617783
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -90,35 +90,33 @@
public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc) throws
IOException {
this(cfg, jssc, FSUtils.getFs(cfg.targetBasePath,
jssc.hadoopConfiguration()),
- getDefaultHiveConf(jssc.hadoopConfiguration()));
+ jssc.hadoopConfiguration(), null);
}
public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc,
TypedProperties props) throws IOException {
this(cfg, jssc, FSUtils.getFs(cfg.targetBasePath,
jssc.hadoopConfiguration()),
- getDefaultHiveConf(jssc.hadoopConfiguration()), props);
+ jssc.hadoopConfiguration(), props);
}
- public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs,
HiveConf hiveConf,
- TypedProperties properties) throws IOException {
- this.cfg = cfg;
- this.deltaSyncService = new DeltaSyncService(cfg, jssc, fs, hiveConf,
properties);
+ public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs,
Configuration hiveConf) throws IOException {
+ this(cfg, jssc, fs, hiveConf, null);
}
- public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs,
HiveConf hiveConf) throws IOException {
+ public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs,
Configuration hiveConf,
+ TypedProperties properties) throws IOException {
+ if (cfg.initialCheckpointProvider != null && cfg.bootstrapFromPath != null
&& cfg.checkpoint == null) {
Review comment:
same as above, it will need a code refactoring if we wanna get rid of null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
