vinothchandar commented on a change in pull request #1486: [HUDI-759] Integrate
checkpoint provider with delta streamer
URL: https://github.com/apache/incubator-hudi/pull/1486#discussion_r407233388
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java
##########
@@ -319,18 +331,18 @@ private static Boolean tableExists(Connection conn,
Map<String, String> options)
* @return
* @throws Exception
*/
- public static Schema getJDBCSchema(Map<String, String> options) throws
Exception {
- Connection conn = createConnectionFactory(options);
- String url = options.get(JDBCOptions.JDBC_URL());
- String table = options.get(JDBCOptions.JDBC_TABLE_NAME());
- boolean tableExists = tableExists(conn,options);
+ public static Schema getJDBCSchema(final Map<String, String> options) throws
Exception {
+ final Connection conn = createConnectionFactory(options);
Review comment:
I get where you are coming from for `final` but given we are not following
this everywhere.. can we please limit this PR to the minimal changes needed for
this functionality..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
