codope commented on code in PR #6890:
URL: https://github.com/apache/hudi/pull/6890#discussion_r1002375045
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -792,6 +792,15 @@ public final Stream<HoodieFileGroup>
getAllFileGroups(String partitionStr) {
return getAllFileGroupsIncludingReplaced(partitionStr).filter(fg ->
!isFileGroupReplaced(fg));
}
+ @Override
+ public final Stream<Pair<String, List<HoodieFileGroup>>>
getAllFileGroups(List<String> partitionPaths) {
Review Comment:
Instead of a separate api in the interface, let's extract the logic to a
separate methos in CleanPlanner.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java:
##########
@@ -149,10 +149,12 @@ interface SliceView extends SliceViewWithLatestSlice {
*/
Stream<HoodieFileGroup> getAllFileGroups(String partitionPath);
+ Stream<Pair<String, List<HoodieFileGroup>>> getAllFileGroups(List<String>
partitionPaths);
Review Comment:
We can do away with this api, doesn't add much value. Instead, we can
directly use the `getAllFileGroups(String partitionPath)` api at the call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
