codope commented on PR #6962: URL: https://github.com/apache/hudi/pull/6962#issuecomment-1287650595
@lxxawfl Thanks for this fix. Unfortunately, if we upgrade guava here then it will run into conflict when we upgrade hudi-presto-bundle version in prestodb https://github.com/prestodb/presto/blob/0.277/pom.xml#L1263. I tried to build presto with hudi-presto-bundle incorporating this fix and it ran into following build failure: ``` [INFO] --- duplicate-finder-maven-plugin:1.2.1:check (default) @ presto-hive --- [INFO] Checking compile classpath [INFO] Checking runtime classpath [INFO] Checking test classpath [WARNING] Found duplicate and different classes in [com.google.guava:guava:26.0-jre, org.apache.hudi:hudi-presto-bundle:0.13.0-SNAPSHOT]: [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixPatterns [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixType [WARNING] com.google.thirdparty.publicsuffix.TrieParser [WARNING] Found duplicate classes/resources in compile classpath. [WARNING] Found duplicate and different classes in [com.google.guava:guava:26.0-jre, org.apache.hudi:hudi-presto-bundle:0.13.0-SNAPSHOT]: [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixPatterns [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixType [WARNING] com.google.thirdparty.publicsuffix.TrieParser [WARNING] Found duplicate classes/resources in runtime classpath. [WARNING] Found duplicate and different classes in [com.google.guava:guava:26.0-jre, org.apache.hudi:hudi-presto-bundle:0.13.0-SNAPSHOT]: [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixPatterns [WARNING] com.google.thirdparty.publicsuffix.PublicSuffixType [WARNING] com.google.thirdparty.publicsuffix.TrieParser [WARNING] Found duplicate classes/resources in test classpath. ... ... [ERROR] Failed to execute goal org.basepom.maven:duplicate-finder-maven-plugin:1.2.1:check (default) on project presto-hive: Found duplicate classes/resources! -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
